West-Midlands | 26-ITP-May | Maryam Janjua | Sprint 3 | Implement and Rewrite Tests - #1603
Open
maryam-devio wants to merge 6 commits into
Open
maryam-devio wants to merge 6 commits into
maryam-devio wants to merge 6 commits into
Conversation
maryam-devio
added
📅 Sprint 3
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
maryam-devio
changed the title
maryam-devio
added
the
Needs Review
cjyuan
reviewed
Aug 10, 2026
cjyuan
added
Reviewed
maryam-devio
added
Needs Review
Author
|
Hello! Thank you for the comments. I’ve made all the changes you mentioned in all files and pushed the updates as well. Thank you! |
cjyuan
reviewed
Aug 12, 2026
Comment on lines
+15
to
+21
| if (denominator === 0){ | ||
| return false; | ||
| } | ||
| if(Math.abs(numerator) < Math.abs(denominator)){ | ||
| return true; | ||
| } | ||
| else{ |
Contributor
There was a problem hiding this comment.
Why not use a formatter to keep the code consistently formatted?
Comment on lines
+26
to
+34
| if(card=="A♠" || card=="A♥" || card=="A♦" || card == "A♣"){ | ||
| return 11; | ||
| } | ||
| if(card=="J♠" || card=="J♥" || card=="J♦" || card == "J♣" || | ||
| card=="Q♠" || card=="Q♥" || card=="Q♦" || card == "Q♣" || | ||
| card=="K♠" || card=="K♥" || card=="K♦" || card == "K♣" | ||
| ){ | ||
| return 10; | ||
| } |
Contributor
There was a problem hiding this comment.
Note: Code works but could probably be simplified.
| }); | ||
|
|
||
| // Proper fractions with positive values | ||
| test("should return true when the absolute value of the numerator is less than the absolute value of the denominator", () => { |
Contributor
There was a problem hiding this comment.
Note: We could also use pseudo-code and math notations like abs(...) or | ... | to denote "absolute value of" in the descriptions.
cjyuan
added
Complete
Member
|
Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it. |
|
Your PR didn't include a Task ID in its description. Make sure you have put the correct Task ID in its description. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have implement all the tasks according to the requirements, and test all the changes made.